0000448: incron wish list for "normal" users :)

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000448

incron

public

2010-05-21 00:57

2009-12-25 17:53

Reporter

fhanzlik

Assigned To

luk

Priority

normal

Severity

minor

Reproducibility

N/A

Status

assigned

Resolution

open

Platform

OS Version

Summary

0000448: incron wish list for "normal" users :)

Description

I report it to Fedoras Bugzilla ( https://bugzilla.redhat.com/show_bug.cgi?id=549010 [^] ), but I was referred here. Than there slightly more detailed opinion and request for improvements:

- allow comments in incrontab files (when they must start on first column
should be fine). This should be usefull e.g. for templates possibility, events
list for these not quite familiar with inotify,...

- incron documentation should be more accurately/detailed

- allow <TAB> along with <SPACE> as separator between <path> <mask> <command>
fields for more comprehensible human view. I not tried it, but probably path field can be escaped, when it contains certain special chars, then it should not be problem.

- when manually editing system tables, editors are frequenly configured for
leaving original file as backup with tilde appended to name. But incrond take
this backups as its valid files, what is some confusing and different from
majority of other programs behavior. I think, optimal is consider only files
with given suffix (e.g. ".conf", as it is in apache and others). In this manner should be reduce couple event switching (as I see in /var/log/cron) after editing system tables, which probably arises when edited table is renamed/moved/etc. I'm not sure, when it may be cause of it (incrond itself cannot be quilty for), but I have in my /var/log/messages oops like:

Dec 20 05:20:03 franta kernel: ------------[ cut here ]------------
Dec 20 05:20:03 franta kernel: WARNING: at fs/notify/inotify/inotify_fsnotify.c:129 idr_callback+0x32/0x56() (Not tainted)
Dec 20 05:20:03 franta kernel: Hardware name: P5E-VM HDMI
Dec 20 05:20:03 franta kernel: inotify closing but id=0 for entry=ed0b8900 in group=d657d600 still in idr. Probably leaking memory
Dec 20 05:20:03 franta kernel: Modules linked in: bluetooth rfkill hfs hfsplus nls_utf8 fuse ipt_MASQUERADE iptable_nat nf_nat nfsd exportfs autofs4 nfs lockd fscache nfs_acl auth_rpcgss sunrpc bridge stp llc cpufreq_ondemand acpi_cpufreq dm_multipath kvm_intel kvm uinput snd_hda_codec_intelhdmi snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm snd_timer firewire_ohci snd firewire_core crc_itu_t iTCO_wdt soundcore iTCO_vendor_support asus_atk0110 i2c_i801 snd_page_alloc atl1 serio_raw e100 mii ata_generic pata_acpi pata_jmicron i915 drm_kms_helper drm i2c_algo_bit i2c_core video output [last unloaded: microcode]
Dec 20 05:20:03 franta kernel: Pid: 7426, comm: incrond Not tainted 2.6.31.6-162.fc12.i686.PAE #1
Dec 20 05:20:03 franta kernel: Call Trace:
Dec 20 05:20:03 franta kernel: [<c043db1b>] warn_slowpath_common+0x70/0x87
Dec 20 05:20:03 franta kernel: [<c04edbfc>] ? idr_callback+0x32/0x56
Dec 20 05:20:03 franta kernel: [<c043db70>] warn_slowpath_fmt+0x29/0x2c
Dec 20 05:20:03 franta kernel: [<c04edbfc>] idr_callback+0x32/0x56
Dec 20 05:20:03 franta kernel: [<c059ce18>] idr_for_each+0x5c/0x97
Dec 20 05:20:03 franta kernel: [<c04edbca>] ? idr_callback+0x0/0x56
Dec 20 05:20:03 franta kernel: [<c04ec2b0>] ? fsnotify_put_event+0x48/0x4b
Dec 20 05:20:03 franta kernel: [<c04edbb9>] inotify_free_group_priv+0x1a/0x2b
Dec 20 05:20:03 franta kernel: [<c04ec38f>] fsnotify_final_destroy_group+0x1e/0x28
Dec 20 05:20:03 franta kernel: [<c04ec453>] fsnotify_put_group+0x75/0x78
Dec 20 05:20:03 franta kernel: [<c04edd71>] inotify_release+0x1e/0x28
Dec 20 05:20:03 franta kernel: [<c04c9bd7>] __fput+0xed/0x184
Dec 20 05:20:03 franta kernel: [<c04c9c86>] fput+0x18/0x1a
Dec 20 05:20:03 franta kernel: [<c04c7129>] filp_close+0x56/0x60
Dec 20 05:20:03 franta kernel: [<c043f480>] put_files_struct+0x5d/0xa1
Dec 20 05:20:03 franta kernel: [<c043f4f7>] exit_files+0x33/0x37
Dec 20 05:20:03 franta kernel: [<c0440c60>] do_exit+0x1cb/0x5da
Dec 20 05:20:03 franta kernel: [<c04410d5>] do_group_exit+0x66/0x8d
Dec 20 05:20:03 franta kernel: [<c0441114>] sys_exit_group+0x18/0x1c
Dec 20 05:20:03 franta kernel: [<c0408f9b>] sysenter_do_call+0x12/0x28
Dec 20 05:20:03 franta kernel: ---[ end trace bf2ba6f50ae90f71 ]---
Dec 20 05:20:03 franta kernel: entry->group=(null) inode=(null) wd=1024
Dec 20 05:20:08 franta abrt: Kerneloops: Reported 1 kernel oopses to Abrt

and incrond ends with "IN_IGNORED" flag for certains events and there isn't (I think) other chance to return to normal behavior than restart it. Absolutely inacceptable for productional usage, but as it is rather kernel bug, still uncorrected (F12 2.6.31.6-166.fc12.i686.PAE kernel), why shall incrond uselessly provoke kernel for this?
And as for comments in incrotabs, I can imagine as usefull e.g. some sort an README in /etc/incron.d/ which is usefull for admins, but is ignored by incrond.

Notes
(0000440) fhanzlik (reporter) 2009-12-22 01:40	as I see there in another contribution, possibility to sending mails as cron does is quite fine stuff - my incrond invoked script can come to unpredictable situations, and then mails with its stderr outputs may be very usefull. One further vote for this feature, please.

(0000441) luk (administrator) 2009-12-25 17:53	As I can see here all of these improvements has already been requested. They will be implemented in the next major version (0.6.0).

Issue History
Date Modified	Username	Field	Change
2009-12-22 01:30	fhanzlik	New Issue
2009-12-22 01:40	fhanzlik	Note Added: 0000440
2009-12-25 17:50	luk	Status	new => assigned
2009-12-25 17:50	luk	Assigned To	=> luk
2009-12-25 17:53	luk	Note Added: 0000441

Relationships