| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0000452 | inotify-cxx | | public | 2010-05-21 00:57 | 2010-03-23 23:34 |
|
| Reporter | gvegidy | |
| Assigned To | luk | |
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | assigned | Resolution | open | |
| Platform | | OS | | OS Version | |
|
| Summary | 0000452: use namespace |
| Description | if inotify-cxx is used together with other code or libraries, the other code may happen to use a variable, classname, typedef,... with the same name as inotify-cxx. This results in a name clash and lots of trouble.
The solution is to embed each lib in it's own namespace.
I have attached a patch which implements this.
If you don't expect any name clashes, you can write
using namespace inotify;
at the top of your program and everything works as before.
|
| Tags | No tags attached. |
|
| Attached Files |  inotify-cxx-0.7.3-namespace.patch [^] (1,101 bytes) 2010-03-12 20:31 [Show Content] [Hide Content]Common subdirectories: inotify-cxx-0.7.3.orig/doc and inotify-cxx-0.7.3/doc
diff -u inotify-cxx-0.7.3.orig/inotify-cxx.cpp inotify-cxx-0.7.3/inotify-cxx.cpp
--- inotify-cxx-0.7.3.orig/inotify-cxx.cpp 2009-12-09 22:41:51.000000000 +0100
+++ inotify-cxx-0.7.3/inotify-cxx.cpp 2010-03-12 19:12:23.000000000 +0100
@@ -48,7 +48,8 @@
} \
})
-
+namespace inotify
+{
int32_t InotifyEvent::GetDescriptor() const
{
@@ -639,3 +640,4 @@
return path;
}
+}
Only in inotify-cxx-0.7.3: inotify-cxx.cpp~
diff -u inotify-cxx-0.7.3.orig/inotify-cxx.h inotify-cxx-0.7.3/inotify-cxx.h
--- inotify-cxx-0.7.3.orig/inotify-cxx.h 2009-12-09 22:41:51.000000000 +0100
+++ inotify-cxx-0.7.3/inotify-cxx.h 2010-03-12 19:11:44.000000000 +0100
@@ -34,6 +34,9 @@
#include <deque>
#include <map>
+namespace inotify
+{
+
// Please ensure that the following header file takes the right place
#include <sys/inotify.h>
@@ -882,6 +885,7 @@
static std::string GetCapabilityPath(InotifyCapability_t cap) throw (InotifyException);
};
+}
#endif //_INOTIFYCXX_H_
Only in inotify-cxx-0.7.3: inotify-cxx.h~
|
|
Relationships 
Relationships 